The TS-GitLab will have to shut down towards the end of the year — please think about migrating your projects to GitLab.com or GitHub.
(This is still a very early message, meant to keep you informed. There will be more urgent ones in the future.)

Commit b5d4eb66 authored by Lukas Riedel's avatar Lukas Riedel

Fix typo in OBB scheme

* Fix typo by renaming OOB scheme to OBB scheme.
* Add warning for experimental DG settings.
parent 0085c742
......@@ -334,13 +334,14 @@ adding an empty line, make text **bold** or ``monospaced``.
**NIPG:** Non-Symmetric Interior Penalty
**OOB:** Oden, Babuska, Baumann: no penalty term
**OBB:** Oden, Babuska, Baumann: no penalty term
**IIP:** Incomplete Interior Penalty: no symmetry term
</definition>
<values> SIPG, NIPG, OOB, IIP </values>
<values> SIPG, NIPG, OBB, IIP </values>
<suggestion> SIPG </suggestion>
<comment> Experimental settings are enabled by the appropriate CMake flag.
<comment> Only change these settings if you are sure about what you
are doing!
</comment>
</parameter>
......
......@@ -70,7 +70,7 @@ namespace Dune {
penalty_factor(config.get<RF>("numerics.penaltyFactor")),
time(0.0)
{
if (method_ == RichardsDGMethod::OOB)
if (method_ == RichardsDGMethod::OBB)
penalty_factor = 0.0;
}
......@@ -310,4 +310,4 @@ namespace Dune {
} // namespace Dorie
} // namespace Dune
#endif // DUNE_DORIE_ERROR_INDICATOR_HH
\ No newline at end of file
#endif // DUNE_DORIE_ERROR_INDICATOR_HH
......@@ -32,7 +32,7 @@ struct RichardsDGMethod
{
enum Type { NIPG, //!< Non-symmetric interior penalty
SIPG, //!< Symmetric interior penalty (default)
OOB, //!< Oden, Babuska, Baumann (no penalty term)
OBB, //!< Oden, Babuska, Baumann (no penalty term)
IIP //!< Incomplete interior penalty (no symmetry)
};
};
......@@ -88,8 +88,8 @@ inline auto read_experimental_operator_settings(
method = RichardsDGMethod::SIPG;
else if (method_str == "NIPG")
method = RichardsDGMethod::NIPG;
else if (method_str == "OOB")
method = RichardsDGMethod::OOB;
else if (method_str == "OBB")
method = RichardsDGMethod::OBB;
else if (method_str == "IIP")
method = RichardsDGMethod::IIP;
else {
......@@ -230,12 +230,12 @@ public:
cache(20)
{
theta = 0.; // IIP
if (method == RichardsDGMethod::NIPG || method == RichardsDGMethod::OOB)
if (method == RichardsDGMethod::NIPG || method == RichardsDGMethod::OBB)
theta = 1.;
else if (method == RichardsDGMethod::SIPG)
theta = -1.;
if (method == RichardsDGMethod::OOB)
if (method == RichardsDGMethod::OBB)
penalty_factor = 0.;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment