Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
D
dorie
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
31
Issues
31
List
Boards
Labels
Service Desk
Milestones
Merge Requests
9
Merge Requests
9
Operations
Operations
Incidents
Environments
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
dorie
dorie
Commits
c9a5c46c
Commit
c9a5c46c
authored
Jul 15, 2020
by
Santiago Ospina De Los Ríos
Committed by
Lukas Riedel
Jul 15, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix "unused variable" warnings in H5File
H5File will now log warnings if non-critical assertions fail.
parent
1dd038dd
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletion
+10
-1
CHANGELOG.md
CHANGELOG.md
+1
-0
dune/dorie/common/h5file.hh
dune/dorie/common/h5file.hh
+9
-1
No files found.
CHANGELOG.md
View file @
c9a5c46c
...
...
@@ -14,6 +14,7 @@
### Fixed
*
Compiler warnings for unused variables in
`dune/dorie/common/h5file.hh`
!206
*
Ensure UTF-8 locale definition in Docker images !210
## 2.0.0 (2020-05-14)
...
...
dune/dorie/common/h5file.hh
View file @
c9a5c46c
...
...
@@ -58,6 +58,8 @@ public:
// release properties
herr_t
status
=
H5Pclose
(
h5_plist_id
);
assert
(
status
>
-
1
);
if
(
status
<
0
)
_log
->
warn
(
"Unable to release H5 file properties"
);
// check for errors regardless of build type
if
(
_file_id
<
0
)
{
...
...
@@ -81,6 +83,9 @@ public:
// close the opened file
status
=
H5Fclose
(
_file_id
);
assert
(
status
>
-
1
);
if
(
status
<
0
)
_log
->
warn
(
"Error closing H5 file: {}"
,
_file_path
);
}
/// Return the file path of this object
...
...
@@ -92,14 +97,17 @@ public:
*/
void
open_group
(
const
std
::
string
&
group_path
=
"./"
)
{
_log
->
trace
(
"Opening H5 group: {}"
,
group_path
);
// close the group if we already opened it
if
(
_group_id
>=
0
)
{
herr_t
status
=
H5Gclose
(
_group_id
);
assert
(
status
>
-
1
);
if
(
status
<
0
)
_log
->
warn
(
"Error closing previously opened H5 group"
);
}
// open the new group
_log
->
trace
(
"Opening H5 group: {}"
,
group_path
);
_group_id
=
H5Gopen
(
_file_id
,
group_path
.
c_str
(),
H5P_DEFAULT
);
if
(
_group_id
<
0
)
{
_log
->
error
(
"Failed to open H5 group: {}"
,
group_path
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment