Commit ce64d5da authored by Lukas Riedel's avatar Lukas Riedel 📝 Committed by Santiago Ospina De Los Ríos

Avoid CFL condition to set illicitly large time step

Suggesting a time step to the transport model now sets the end time in
the time step controller. This allows the CFL condition to increase the
time step while remaining inside the time interval limited by the
Richards model.
parent 13413e17
......@@ -70,6 +70,7 @@
* Allow Neumman BC to be applied on a different direction other than gravity !121
* Transport model option `dirichletMode` was not working properly !121
* Use unsafe loader of PyYAML v5.2 for loading parameter scraper data !177
* CFL condition in explicit Transport model serves as time step upper limit !179
### Deprecated
......
......@@ -164,7 +164,7 @@ void ModelTransport<Traits>::step()
double courant = inifile.get<double>("numerics.courant");
assert(courant>0.);
const auto cfl = Dune::Dorie::cfl_condition(*water_flux_gf);
time_step_ctrl.set_time_step(courant*cfl);
time_step_ctrl.suggest_time_step(courant * cfl);
}
// get time step suggestion from boundary conditions
......
include ${CMAKE_BINARY_DIR}/doc/default_files/config.ini
__name = mc
__name = {_ts_method}
_ts_method = implicit, explicit | expand ts_method
_bc_path = "${CMAKE_CURRENT_LIST_DIR}/test-model-coupling"
_param_path = "${PROJECT_SOURCE_DIR}/test/param"
......@@ -53,3 +54,6 @@ end = 100
startTimestep = 10
maxTimestep = 100
timestepIncreaseFactor = 2.0
[transport.numerics]
timestepMethod = implicit_euler, explicit_euler | expand ts_method
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment