dorie issueshttps://ts-gitlab.iup.uni-heidelberg.de/dorie/dorie/-/issues2020-02-13T16:38:01+01:00https://ts-gitlab.iup.uni-heidelberg.de/dorie/dorie/-/issues/147Water flux error estimator must include Neumann boundary condition2020-02-13T16:38:01+01:00Lukas Riedelmail@lukasriedel.comWater flux error estimator must include Neumann boundary condition### Description
The water flux error estimator computes an estimate of the conformity of the solution by integrating jumps in the solution and jumps in the gradient over grid faces.
The error estimator contains two terms:
1. Solution jump $`\propto \gamma [[ u ]] / h_F`$.
At the boundary, the jump is defined by the difference between the interior solution and the Dirichlet boundary condition (zero for Neumann).
2. Gradient jump $`\propto [[ K \nabla u ]]`$.
At the boundary, the jump is defined by the difference between the interior solution gradient and the Neumann boundary condition (zero for Dirichlet). _This is not considered right now._
### Proposal
Add the Neumann boundary condition to the "gradient jump" term in the error indicator.
### How to test the implementation?
Add a unit test: For a very simple 1x1 grid, a constant initial condition and prescribed boundary conditions, compute the error indicator and verify its value.
### Related issues
None### Description
The water flux error estimator computes an estimate of the conformity of the solution by integrating jumps in the solution and jumps in the gradient over grid faces.
The error estimator contains two terms:
1. Solution jump $`\propto \gamma [[ u ]] / h_F`$.
At the boundary, the jump is defined by the difference between the interior solution and the Dirichlet boundary condition (zero for Neumann).
2. Gradient jump $`\propto [[ K \nabla u ]]`$.
At the boundary, the jump is defined by the difference between the interior solution gradient and the Neumann boundary condition (zero for Dirichlet). _This is not considered right now._
### Proposal
Add the Neumann boundary condition to the "gradient jump" term in the error indicator.
### How to test the implementation?
Add a unit test: For a very simple 1x1 grid, a constant initial condition and prescribed boundary conditions, compute the error indicator and verify its value.
### Related issues
Nonev2.0 ReleaseLukas Riedelmail@lukasriedel.comLukas Riedelmail@lukasriedel.comhttps://ts-gitlab.iup.uni-heidelberg.de/dorie/dorie/-/issues/129Default vertexData = true2018-12-18T20:28:32+01:00Santiago Ospina De Los RĂossospinar@gmail.comDefault vertexData = true### Description
The experience with flux reconstruction and solute transport have taught me that cell data does not give us enough meaningful representation of the functions we are solving. Most of the time I have to change the current tests to `vertexData=true` in order to assert that the solution is what I expect.
### Proposal
Hence, I would like to propose to leave `vertexData=true` by default. Whoever wants to save space (e.g. for tests and comparisons in python) is free to come back to `vertexData=false`.
### How to test the implementation?
All tests are passing.
### Related issues
See
<!--
PLEASE READ THIS
Briefly explain __what__ should be changed and __propose__ how this can happen.
Adding pseudo code or diagrams would be great!
Additionally, you can:
- add suitable labels
- assign a milestone
- mention other issues
-->### Description
The experience with flux reconstruction and solute transport have taught me that cell data does not give us enough meaningful representation of the functions we are solving. Most of the time I have to change the current tests to `vertexData=true` in order to assert that the solution is what I expect.
### Proposal
Hence, I would like to propose to leave `vertexData=true` by default. Whoever wants to save space (e.g. for tests and comparisons in python) is free to come back to `vertexData=false`.
### How to test the implementation?
All tests are passing.
### Related issues
See
<!--
PLEASE READ THIS
Briefly explain __what__ should be changed and __propose__ how this can happen.
Adding pseudo code or diagrams would be great!
Additionally, you can:
- add suitable labels
- assign a milestone
- mention other issues
-->v2.0 Releasehttps://ts-gitlab.iup.uni-heidelberg.de/dorie/dorie/-/issues/9[meta] Include Cook Book exercises2020-07-06T15:54:59+02:00Lukas Riedelmail@lukasriedel.com[meta] Include Cook Book exercises_Note:_ This is a meta-task. It bundles several tasks together and is only closed once all these tasks are finished.
### Aims
Dorie was used in the [`PoTS` WS 16/17 lecture](https://elearning2.uni-heidelberg.de/course/view.php?id=13481). The students received some input files for exemplary simulations and had to analyse the results. These simulations can be used for a Cook Book inside our documentation. On the other hand, some new documentation has to be created for the transport part.
### Tasks
* [x] ~"Model:Richards" !157 Infiltration in homogeneous medium
* [ ] ~"Model:Richards" Water retention and hydraulic conductivity curve parameterization
* [x] ~"Model:Richards" Infiltration in heterogeneous medium: !184
* [x] ~"Model:Richards" Infiltration in miller-similar medium !184
* [ ] ~"Model:Richards" Boundary conditions
* [ ] ~"Model:Richards" Adaptive grid refinement
* [ ] ~"Model:Richards" Unstructured grids
* [ ] ~"Model:Transport" !158 Solute transport in homogeneous medium
* [ ] ~"Model:Transport" Effective hydrodynamic dispersion tensor parameterization
<!-- Remember to mention tasks with '#' here, once they are created. -->
### People involved
@sospinar
@lriedel
### Related meta-tasks
<!-- Meta-tasks of other groups that require coordination -->
<!--
PLEASE READ THIS
A meta task is used to organise and discuss several regular tasks.
When creating this meta task, please take care of the following:
- When new tasks that belong to this meta-task are created,
link them here, and add them as tasks
- Attach the correct labels
- Mention the people that should get involved
- Assign the correct milestone (if available)
-->_Note:_ This is a meta-task. It bundles several tasks together and is only closed once all these tasks are finished.
### Aims
Dorie was used in the [`PoTS` WS 16/17 lecture](https://elearning2.uni-heidelberg.de/course/view.php?id=13481). The students received some input files for exemplary simulations and had to analyse the results. These simulations can be used for a Cook Book inside our documentation. On the other hand, some new documentation has to be created for the transport part.
### Tasks
* [x] ~"Model:Richards" !157 Infiltration in homogeneous medium
* [ ] ~"Model:Richards" Water retention and hydraulic conductivity curve parameterization
* [x] ~"Model:Richards" Infiltration in heterogeneous medium: !184
* [x] ~"Model:Richards" Infiltration in miller-similar medium !184
* [ ] ~"Model:Richards" Boundary conditions
* [ ] ~"Model:Richards" Adaptive grid refinement
* [ ] ~"Model:Richards" Unstructured grids
* [ ] ~"Model:Transport" !158 Solute transport in homogeneous medium
* [ ] ~"Model:Transport" Effective hydrodynamic dispersion tensor parameterization
<!-- Remember to mention tasks with '#' here, once they are created. -->
### People involved
@sospinar
@lriedel
### Related meta-tasks
<!-- Meta-tasks of other groups that require coordination -->
<!--
PLEASE READ THIS
A meta task is used to organise and discuss several regular tasks.
When creating this meta task, please take care of the following:
- When new tasks that belong to this meta-task are created,
link them here, and add them as tasks
- Attach the correct labels
- Mention the people that should get involved
- Assign the correct milestone (if available)
-->v2.0 Release