dorie issues https://ts-gitlab.iup.uni-heidelberg.de/dorie/dorie/-/issues 2018-10-07T18:13:08+02:00 https://ts-gitlab.iup.uni-heidelberg.de/dorie/dorie/-/issues/39 write test for global mass conservation 2018-10-07T18:13:08+02:00 Lukas Riedel mail@lukasriedel.com write test for global mass conservation We have to test if global water mass is conserved. To do so, we need a new local operator which computes $ V_w = \sum_{T} \int_T \theta_w $. We can then compare the temporal change of this quantity to the fluxes into and out of the domain, $ d V_w / dt = \sum_{F} \int_F j_N $. We have to test if global water mass is conserved. To do so, we need a new local operator which computes $ V_w = \sum_{T} \int_T \theta_w $. We can then compare the temporal change of this quantity to the fluxes into and out of the domain, $ d V_w / dt = \sum_{F} \int_F j_N $. v1.0 Release Lukas Riedel mail@lukasriedel.com Lukas Riedel mail@lukasriedel.com https://ts-gitlab.iup.uni-heidelberg.de/dorie/dorie/-/issues/54 Raise mass conservation limits 2018-03-16T19:44:40+01:00 Lukas Riedel mail@lukasriedel.com Raise mass conservation limits #### Summary Apparently, !14 changed the results of the mass conservation test. This might be due to the different time step behavior, as the tests run much faster now. This indicates that global mass conservation also depends on time step size. #### What is the current behaviour? Mass conservation test for static simplex grid fails. Mass conservation is three orders of magnitude worse than expected. ### Proposal * Raise mass conservation limits to appropriate value * Add tests on rectangular grids again, because execution time is much lower now. #### Summary Apparently, !14 changed the results of the mass conservation test. This might be due to the different time step behavior, as the tests run much faster now. This indicates that global mass conservation also depends on time step size. #### What is the current behaviour? Mass conservation test for static simplex grid fails. Mass conservation is three orders of magnitude worse than expected. ### Proposal * Raise mass conservation limits to appropriate value * Add tests on rectangular grids again, because execution time is much lower now. v1.0 Release Lukas Riedel mail@lukasriedel.com Lukas Riedel mail@lukasriedel.com