[meta] Revamp boundary condition input and handling (#119) · Issues · dorie / dorie

[meta] Revamp boundary condition input and handling

Note: This is a meta-task. It bundles several tasks together and is only closed once all these tasks are finished.

Aims

This meta-tasks aims at a complete revamp of the input and internal handling of boundary conditions, in a similar way as #63 (closed) rebuilt the paramterization. The new scheme should offer more flexibility, while using explicit mappings to the grid elements (boundary segments).

Again, this feature will be split up into several tasks:

Rebuilding the file input and mapping, which builds upon the classes created in #86 (closed)
Using new data structures for representing boundary conditions
Create internal mappings similar to the ones in FlowParameters for efficient access
Reworking the adaptation of time steps to boundary condition changes in CalculationController
Wrapping everything together

Tasks

#124 (closed): Remove BC options evaporation and limitedInflux, they never really worked
#123 (closed): Implement new way of specifying boundary segmentations
#126 (closed): Implement new input of boundary condition data
#125 (closed): Create new data structure for storing and accessing boundary conditions
!121 (merged): Merge everything into revamped FlowBoundary

People involved

@lriedel, @sospinar (for review?)

Related issues

#63 (closed) Rebuild of parameterization input
#29 (closed) Use yaml-cpp for BC input file

_Note:_ This is a meta-task. It bundles several tasks together and is only closed once all these tasks are finished.

### Aims
This meta-tasks aims at a complete revamp of the input and internal handling of boundary conditions, in a similar way as #63 rebuilt the paramterization. The new scheme should offer more flexibility, while using explicit mappings to the grid elements (boundary segments).

Again, this feature will be split up into several tasks:

* Rebuilding the file input and mapping, which builds upon the classes created in #86
* Using new data structures for representing boundary conditions
* Create internal mappings similar to the ones in `FlowParameters` for efficient access
* Reworking the adaptation of time steps to boundary condition changes in `CalculationController`
* Wrapping everything together

### Tasks
* [x] #124: Remove BC options `evaporation` and `limitedInflux`, they never really worked
* [x] #123: Implement new way of specifying boundary segmentations
* [x] #126: Implement new input of boundary condition data
* [x] #125: Create new data structure for storing and accessing boundary conditions
* [x] !121: Merge everything into revamped `FlowBoundary`

### People involved
@lriedel, @sospinar (for review?)

### Related issues

* #63 Rebuild of parameterization input
* #29 Use `yaml-cpp` for BC input file

<!--
PLEASE READ THIS

A meta task is used to organise and discuss several regular tasks.

When creating this meta task, please take care of the following:
    - When new tasks that belong to this meta-task are created,
        link them here, and add them as tasks
    - Attach the correct labels
    - Mention the people that should get involved
    - Assign the correct milestone (if available)
-->

Edited Sep 25, 2019 by Lukas Riedel

Discussion
Designs

The one place for your designs

To enable design management, you'll need to meet the requirements. If you need help, reach out to our support team for assistance.