GitLab

dirichletMode is a new parameter in [solute.boundary], but it's never evaluated.

Summary

dirichletMode is supposed as a switch to determine if the Dirichlet parameter means the solute concentration in the total volue (totalConcentration) c_t or the concentration in the water phase (soluteConcentration) c_w (in which the solution is actually evaluated. This key is never read from the parameter file. By default, the local operator sets the mode to DirichletMode::SoluteConcentration, see local_operator_FV.hh#L122.

I also have to say that I am a bit confused about the code where this mode is queried inside the operator, see local_operator_FV.hh#L377. Why would the water content at any time be lower than zero, and why does the boundary condition then become zero?

Steps to reproduce

Set dirichletMode to totalSolute. Nothing happens.

What is the current bug behaviour?

dirichletMode is not evaluated.

What is the expected correct behaviour?

dirichletMode adjusts the Dirichlet boundary condition as specified.

Relevant logs, screenshots, files...?

Ideas how to fix this?

I discovered this when merging master into !121 (merged). I guess I can resolve this in there, as it rebuilds the way boundary conditions are stored and queried. I think it would be useful if one could declare this setting in the BC file, and for every Dirichlet BC separately. This should be possible with the new setup.