Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

The TS-GitLab will have to shut down towards the end of the year — please think about migrating your projects to GitLab.com or GitHub.
(This is still a very early message, meant to keep you informed. There will be more urgent ones in the future.)

  • dorie
  • dorie
  • Issues
  • #154

Closed
Open
Created May 14, 2019 by Lukas Riedel@lriedelOwner

Linear interpolator only works for minimal shapes and trivial extensions

Due to bad unit test design, a silly bug in the code of the linear interpolator went unnoticed. The interpolator yields wrong results whenever the extensions into one direction are not 1.0, and the shape is larger than 2.

Summary

Index queries in the linear interpolator were done with the actual coordinates instead of the coordinates in "mesh dimensions".

Steps to reproduce

Using any dataset that does not have the minimal shape or that is interpolated onto a grid with non-trivial extensions leads to a wrong result. In this case, I used a very simple dataset as input, but the result was off (see below).

The issue is caused by calling get_knot_indices() with the wrong argument pos instead of pos_unit.

Relevant logs, screenshots, files...?

The input dataset Screen_Shot_2019-05-14_at_18.47.06

results in the initial condition:

Screen_Shot_2019-05-15_at_16.03.59

Ideas how to fix this?

Call get_knot_indices() with pos_unit and improve the unit test to capture the expected behavior better.

Edited May 15, 2019 by Lukas Riedel
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None