Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

The TS-GitLab will have to shut down towards the end of the year — please think about migrating your projects to GitLab.com or GitHub.
(This is still a very early message, meant to keep you informed. There will be more urgent ones in the future.)

  • dorie
  • dorie
  • Issues
  • #159

Closed
Open
Created Aug 09, 2019 by Lukas Riedel@lriedelOwner0 of 1 task completed0/1 task

Follow-up from "Resolve "Add upwinding option to Richards FV solver""

The following discussion from !161 (merged) should be addressed:

  • @sospinar started a discussion: (+2 comments)

    The normal vector is positive to the outside of the cell. That means that this the negative value of \frac{\partial u}{\partial \vec{n}}. Of course this is doing the same as before, but I find it more clear if it has the correct sign (as the DG local operator).

The resulting change in 5e15de0e should also have inverted the checks for upwinding. It did not, which is why the upwinding now effectively is a downwinding in the FV solver. The ODE tests did not notice that change, which becomes mostly apparent in transient states.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None