Tests are not being configured correctly
Summary
The CMake function dorie_add_metaini_test
in dorie requests a TARGET
argument which is later passed to the dune-testtools
function dune_add_system_test
. The latter is wrong because the function dune_add_system_test
does not request an ´TARGET´ argument or at least not intentionally exposed to the end user (From the source code I deduce that it is internally used to dynamically assign created targets).
On the other hand, the dorie
target is not an executable as the function add_static_variants
requires. (add_static_variants
is used within dune_add_system_test
). This explains why the pipeline fails now that dune-testtools
allow executables to be placed anywhere.
Steps to reproduce
Use the current marter
branch of dorie
together with the current master
branch of dune-testtools
.
What is the current bug behaviour?
Test fail to be configured by CMake and therefore, pipeline fails.
What is the expected correct behaviour?
Tests are well configured by CMake.