Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Issues
  • #161

Closed
Open
Opened Sep 08, 2019 by Santiago Ospina De Los Ríos@sospinarMaintainer

Tests are not being configured correctly

Summary

The CMake function dorie_add_metaini_test in dorie requests a TARGET argument which is later passed to the dune-testtools function dune_add_system_test. The latter is wrong because the function dune_add_system_test does not request an ´TARGET´ argument or at least not intentionally exposed to the end user (From the source code I deduce that it is internally used to dynamically assign created targets).

On the other hand, the dorie target is not an executable as the function add_static_variants requires. (add_static_variants is used within dune_add_system_test). This explains why the pipeline fails now that dune-testtools allow executables to be placed anywhere.

Steps to reproduce

Use the current marter branch of dorie together with the current master branch of dune-testtools.

What is the current bug behaviour?

Test fail to be configured by CMake and therefore, pipeline fails.

What is the expected correct behaviour?

Tests are well configured by CMake.

Relevant logs, screenshots, files...?

Job #61906 failed for 48133574:

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
v2.0 Release
Milestone
v2.0 Release
Assign milestone
Time tracking
None
Due date
None
Reference: dorie/dorie#161