Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Issues
  • #45

Closed
Open
Opened Feb 22, 2018 by Lukas Riedel@lriedelOwner

maxIterations depends on minTimestep

In the constructor of CalculationController, eps is used to instantiate itmax as an increased value from time.maxIterations. However, eps is instantiated from dtmin, which can cause trouble if the latter is set too high. Specifically, itmax was decreased below itmin, which caused the solver to fail.

Solution: Use rounding in calcIterations, save iterations as integers, remove eps from itmax constructor.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
v1.0 Release
Milestone
v1.0 Release
Assign milestone
Time tracking
None
Due date
None
Reference: dorie/dorie#45