Order procedures and suggestions regarding solute transport
There have been a couple of suggestions and discussions regarding improvements of DORiE. Most, but not all of them are related to the goal of incorporating solute transport into the current framework. This issue is intended to bring order into this and to discuss how to proceed.
@sospinar, I'd like you to comment (shortly) on the issues and my considerations below and order them by importance or precedence. I also hope to ensure that your development version doesn't diverge too far from the DORiE main build. You are working pretty fast and incorporating large changes back in can be a huge pain in the
Finally, I also have to consider which features enter the next release(s), but this is a minor concern.
Outdated issues / MRs
- #40 (closed): In recent discussions, we decided to implement solute transport in the DORiE framework and only use portions of the dune-modelling module.
- !30 (closed): Since #40 (closed) is outdated, we can close this MR.
- #63: Can new parameters required for solute transport be implemented in the current setup, or with a small workaround? Then this issue can be considered independent.
- #62 (closed): Problems with the flux output in 'vertex' mode are related to the missing flux reconstruction which is also necessary for computing solute transport. I guess this should be one of the primary goals then?
- #11 (closed): The subsampling VTK writer previously showed artifacts in matric head and flux, especially after grid refinement. After !21 (merged), !43 (merged), and resolving #62 (closed), we can checkout if it works correctly and if we can finally have full precision output.
How to order everything
I consider the solute transport part a major undertaking, so I'd like to open up a new Milestone. Work can then be split up into meta-tasks with several issues each, see #52 and utopia/utopia#7 (closed) for examples of such a procedure. The idea is to have a meta-task for each 'larger' feature, that is then split up into small work assignments. We have had very good results with this kind of ordering in the Utopia project, so I'd like to uphold it here as well.