Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Issues
  • #90

Closed
Open
Opened Aug 15, 2018 by Santiago Ospina De Los Ríos@sospinarMaintainer

Split AdaptivityHandler::adapt_grid() method into two parts: mark_grid and adapt_grid

Description

Split AdaptivityHandler::adapt_grid() into two parts: mark_grid() and adapt_grid()

Proposal

When coupling models, the so-called superstructure has to be the one who calls the method adapt_grid() from PDELab. In particular, because it has to provide all the vectors and grid function spaces packed together. Is just not possible to do it independently without breaking other models.

However, the mark_grid() method can be called independently by one or more models so that the model marks the grid where is more convenient for its own solution. (is not very likely that we want several models marking the grid at once)

Then the idea is to separate these two concepts in the AdaptivityHandler so that the superstructure can ask to one of the models to mark the grid, and later adapt it for all of the solutions.

See discussion in #94 (closed) for adaptivity of coupled models.

How to test the implementation?

  • The RichardsSimulation is doing the same adaptivity as before.
  • The new superstructure is able to perform the same adaptivity as RichardsSimulation.

Related issues

See #72 (closed), #94 (closed)

Edited Aug 20, 2018 by Santiago Ospina De Los Ríos
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Solute Transport Feature
Milestone
Solute Transport Feature
Assign milestone
Time tracking
None
Due date
None
Reference: dorie/dorie#90