Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dorie
  • dorie
  • Merge Requests
  • !106

Merged
Opened Sep 24, 2018 by Lukas Riedel@lriedelOwner4 of 4 tasks completed4/4 tasks

Resolve "Add a logging framework for command line output"

  • Overview 1
  • Commits 37
  • Pipelines 13
  • Changes 46

What does this MR do?

Use loggers for the entire terminal output of DORiE.

  • Replace config keys verbose with logLevel, taking the same names as defined by spdlog
  • Rename setup_inifile.hh to setup.hh and add functions:
    • Setup::init initializes the MPI helper, the config file, and the base logger
    • Setup::debug_hook halts the program for a debugger to hook into the program
  • Add logger as optional argument to most classes, such that they use a certain logger by default or the one specified by the programmer
  • Add developer docs on how to use the loggers

Is there something that needs to be double checked?

All DUNE output (other than exceptions) is currently suppressed. One option would be to write a stream buffer, into which the output of functions like PDELab::mark_grid is stored. This storage could then be accessed and displayed via a logger at a certain log level setting.

Can this MR be accepted?

  • Implemented logging feature
  • Pipeline passing
  • Updated README.md with information on Git Submodule
  • Added entry to CHANGELOG.md

Related issues

Closes #92 (closed)

What does the new output look like?

Log levels on info:

Screen_Shot_2018-10-26_at_15.03.23

Log levels on debug:

Screen_Shot_2018-10-26_at_15.37.26

Log levels on trace:

Screen_Shot_2018-10-26_at_15.39.52

with adaptivity

debug:

Screen_Shot_2018-10-26_at_15.42.33

trace:

Screen_Shot_2018-10-26_at_15.43.12

Edited Nov 02, 2018 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
v2.0 Release
Milestone
v2.0 Release
Assign milestone
Time tracking
Reference: dorie/dorie!106
Source branch: 92-add-a-logging-framework-for-command-line-output