Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !110

Merged
Opened Sep 27, 2018 by Lukas Riedel@lriedelOwner20 of 20 tasks completed20/20 tasks

Resolve "Add scaling field input"

  • Overview 17
  • Commits 38
  • Pipelines 18
  • Changes 38

What does this MR do?

Add option to input global Miller scaling fields and supply framework for generalized scaling field input

  • Revamp interpolators to be more generic and hold actual data

    • Add base class and factory

    • Add Nearest-Neighbor interpolator

    • [ ] Have interpolators implement GridFunctionBase

      Not possible because current interface does not supply the necessary grid view.

    • Add unit test for interpolator

  • Add adapters for evaluating scaling factors

    • Add base class and factory

    • Add dummy scaling adapter

    • Add Miller scaling adapter

    • [ ] Have scaling adapters implement GridFunctionBase

      Not possible because current interface does not supply the necessary grid view.

    • Add unit test for scaling adapter

  • Add infrastructure

    • Add section to documentation of soil parameters and architecture
    • Add ExponentialConverter with parameters to field-parameters.xml
    • Add parameterization file param.yml to default_files
  • Rewrite test-parameterization not to use RichardsSimulation anymore.

  • Add unit test test-parameterization-scaled, ensuring that scaling is correctly applied wrt. the regular parameterization.

Is there something that needs to be double checked?

  • test-parameterization does not compile a RichardsSimulation anymore. Therefore, many source files are not compiled with --coverage flags and don't appear in the gcovr output at all. This artificially raises the Coverage. Not sure how to solve this.

Can this MR be accepted?

  • Implemented stuff
  • Added unit tests
  • [ ] Added system test Not required. test-parameterization-scaled checks if scaling can be applied in context of FlowParameters.
  • Merged master into this branch
  • Pipeline passing
  • Added entry to CHANGELOG.md

Related issues

Closes #110 (closed), #18 (closed)

Edited Oct 26, 2018 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: dorie/dorie!110
Source branch: 110-add-scaling-field-input

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.