Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !112

Merged
Opened Oct 05, 2018 by Santiago Ospina De Los Ríos@sospinarMaintainer11 of 11 tasks completed11/11 tasks

Resolve "Add DG local operator to the SimulationTransport class"

  • Overview 83
  • Commits 117
  • Pipelines 107
  • Changes 26

What does this MR do?

This MR adds a local operator for the Discontinuous Galerkin method for the diffusion transport equation in the transport model. This local operator is based on the PDELab local operator for the convection-diffusion equation in the pdelab repository and adapted for the specific use case of DORiE. That is: usage of a velocity field provided by another operator and usage of the specific parameterizations for the transport process in unsaturated porous media. Additionally, it has an implementation for adaptivity which targets the diffusive part of the convection-diffusion equation (mainly copied from the Richards model). Edit: Adaptivity module removed from transport solver during review.

Is there something that needs to be double checked?

Is there a way to reduce code duplication?

Can this MR be accepted?

  • Implemented ...
    • DG local operator
    • Implicit time-stepping
    • [ ] Implicit time-stepping parameters in config file
    • Default compilation on RORDER==TORDER
  • Added/Updated tests:
    • Add higher orders to the constant transport test
  • Added/Updated documentation
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

Closes #111 (closed)

Edited Jan 24, 2020 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
Solute Transport Feature
Milestone
Solute Transport Feature
Assign milestone
Time tracking
Reference: dorie/dorie!112
Source branch: 111-add-dg-local-operator-to-the-simulationtransport-class

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.