Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !129

Merged
Opened Dec 28, 2018 by Santiago Ospina De Los Ríos@sospinarMaintainer8 of 8 tasks completed8/8 tasks

Resolve "Implement an abstract base class for initial conditions"

  • Overview 5
  • Commits 14
  • Pipelines 11
  • Changes 16

What does this MR do?

Implement a new scheme for initial conditions based on the proposal in #131 (comment 20535):

  • Implements abstract base classes for initial conditions and their transformations
  • Adds factories for creating generic and model-specific initial conditions

Is there something that needs to be double checked?

No.

Can this MR be accepted?

  • #131 (closed) Implement an abstract base class for initial conditions: InitialCondition.
  • #131 (closed) Implement a initial shape selector based on inifile information. InitialConditionFactory
  • #131 (closed) Use InitialCondition in Richards/TransportSimulation.
  • Added unit test for initial condition input
  • Added docstrings and doxygen module docs
  • Added user doc page
  • Pipeline passing
  • Added entry to CHANGELOG.md

Related issues

Meta-issue: #122 (closed)

Closes #131 (closed)

Edited Jan 14, 2019 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: dorie/dorie!129
Source branch: 131-implement-an-abstract-base-class-for-initial-conditions

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.