Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !14

Merged
Opened Nov 21, 2017 by Lukas Riedel@lriedelOwner7 of 7 tasks completed7/7 tasks

Various fixes to DG implementation and adaptation algorithms

  • Overview 2
  • Commits 20
  • Pipelines 6
  • Changes 27

What does this MR do?

  • Bugfix in upwinding of DG operator, fixing #26 (closed)
  • Add conductivity factor in flux term of Dirichlet boundary condition, resolving #36 (closed)
  • Rebuild of error estimator according to di Petro & Ern, resolving #25 (closed)
    • Include term for Dirichlet boundary condition

Is there something that needs to be double checked?

  • Timeout in some tests: Will be resolved by revamping the tests, see #46 (closed).

Can this MR be accepted?

  • ODE tests are passing
  • Reference tests have small deviation for fixed grids and larger ones for adaptive grids, which was to be expected

Related issues

Closes #25 (closed), #26 (closed) and #36 (closed)

Edited Mar 12, 2018 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
v1.0 Release
Milestone
v1.0 Release
Assign milestone
Time tracking
Reference: dorie/dorie!14
Source branch: development/dorie-v1.0

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.