Skip to content

GitLab

The TS-GitLab will have to shut down towards the end of the year — please think about migrating your projects to GitLab.com or GitHub.
(This is still a very early message, meant to keep you informed. There will be more urgent ones in the future.)

Merged
Created by Lukas Riedel@lriedelOwner5 of 5 tasks completed5/5 tasks

Resolve "Add upwinding option to Richards FV solver"

What does this MR do?

Add upwinding options to the Richards FV local operator. The options are similar to the ones available from the DG operator and have the same names: none, semiUpwind (upwind conductivity factor), and fullUpwind (upwind entire conductivity)). The configuration setting EXPERIMENTAL_DG_SETTINGS has been removed. All settings are now available within the richards.numerics section and are always enabled.

The ODE tests have been adjusted to cover the upwinding cases where adjustment of the tolerance level was not necessary. This is the case for all upwinding schemes of FV. With the DG operator, none and semiUpwind work in homogeneous domains, and only none in heterogeneous (layered) domains. For more information, see !161 (comment 34560)

Additional changes:

  • Fix typo: Rename DG scheme OOB to OBB (Oden, Babuska, Baumann).

Is there something that needs to be double checked?

I guess not.

Can this MR be accepted?

  • Implemented upwinding options
  • Added test cases to ODE tests
  • Update README.md and docs
  • Pipeline passing
  • Added entry to CHANGELOG.md

Related issues

Closes #153 (closed)

Edited by Lukas Riedel