Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dorie
  • dorie
  • Merge Requests
  • !167

Merged
Opened Sep 10, 2019 by Lukas Riedel@lriedelOwner4 of 4 tasks completed4/4 tasks

Resolve "Target 'dorie' excluded from 'all' target"

  • Overview 1
  • Commits 2
  • Pipelines 3
  • Changes 3

What does this MR do?

Add target dorie to default build target. The commands

make
make all

will now properly build all required executables.

Use add_dependencies to indicate dependencies between the targets instead of DEPENDS, as per the add_custom_target docs.

Is there something that needs to be double checked?

  • make all builds dorie and dorie-rfg

Can this MR be accepted?

  • Fixed CMake targets
  • Pipeline passing
  • Added entry to CHANGELOG.md

Related issues

Closes #162 (closed)

Edited Sep 10, 2019 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: dorie/dorie!167
Source branch: 162-target-dorie-excluded-from-all-target