Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !183

Merged
Opened Jan 28, 2020 by Lukas Riedel@lriedel🛀Owner7 of 7 tasks completed7/7 tasks

Update default simulation config files

  • Overview 6
  • Commits 11
  • Pipelines 7
  • Changes 20

What does this MR do?

Improve the default configuration files supplied by dorie create with the aim to

  • execute dorie run immediately after dorie create
  • clarify options and settings

Things changed:

  • Renamed default BC files to <model>_bc.yml.
  • Fixed formatting errors in XML files for boundary.file, preventing the suggested file name to be read.
  • Added and simplified comments in config file.
  • Replace UNDEFINED with NONE for values without suggestions in default config files.

Is there something that needs to be double checked?

No

Can this MR be accepted?

  • Updated default config files
  • Updated test config files
  • Updated documentation
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

See #176 (closed)

Edited Jan 28, 2020 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: dorie/dorie!183
Source branch: run-dorie-create-immediately

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.