Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !187

Merged
Opened Feb 13, 2020 by Lukas Riedel@lriedelOwner8 of 8 tasks completed8/8 tasks

Resolve "Set water content as initial condition"

  • Overview 23
  • Commits 14
  • Pipelines 10
  • Changes 15

What does this MR do?

Add the option to insert water content values as initial condition for the Richards model. The option is activated via richards.initial.quantity = waterContent.

For computing the actual initial condition in terms of the matric head h_m, some additional parameterization functions and a new grid function adapter has been added. Previouly, saturation and water content \theta_w have been computed from the matric head, but not vice versa. The InitialConditionFactory of the Richards model now additionally requires the FlowParameters information.

Changes:

  • Update MualemVanGenuchten and FlowParameters with required methods for computing h_m(\theta_w).
  • Add WaterContentInitialCondition and MatricHeadAdapter.
  • Pass FlowParameters to RichardsInitialConditionFactory.
  • Update the test-initial-condition unit test and make it employ Google Test.
  • Added docs on new initial condition quantity and updated default config file parameters.

Is there something that needs to be double checked?

I had some trouble with the unit test. The Dune::GridView seems to be updated/changed when it is passed to a new thread. Apparently, this is what Google Test does when creating a fixture and passing it to a test case. Therefore, I have to re-build the grid view in every test although it is already built in the test fixture, see f2ada9f3. @sospinar, do you have any knowledge of Dune::GridView not being thread safe?

Can this MR be accepted?

  • Implemented water content as initial condition
  • Added/Updated tests:
    • test-initial-condition
  • Added/Updated documentation
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

Closes #148 (closed)

Edited Apr 06, 2020 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: dorie/dorie!187
Source branch: 148-set-water-content-as-initial-condition

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.