Skip to content

GitLab

Merged
Opened by Santiago Ospina De Los Ríos@sospinarMaintainer8 of 8 tasks completed8/8 tasks

Resolve "Use more recent version of Ubuntu in Docker"

What does this MR do?

Updates base Ubuntu image we use in our CI

  • Update Ubuntu version of base docker image to Ubuntu Focal Fossa 20.04 LTS.
  • Stop vendoring spdlog. Spdlog is now handled like any external dependency and installed into the Docker base image.
  • Bump versions of required software packages to versions available form Ubuntu Focal.
  • Remove deprecated python3-vtk7 bindings package from base image. Add libgl-dev for Python VTK package support.
  • Change base image versioning scheme to reflect Ubuntu version. New scheme: dorie/dune-env:{ubuntu}-v{version}.

Is there something that needs to be double checked?

  • Coverage seems to be reduced by this change. No idea why, it shouldn't be the case.

Can this MR be accepted?

  • Implemented
    • Base image Focal Fossa updated and tested
    • Use spdlog from base image
  • Updated README.md
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

Closes #178 (closed)

Edited by Lukas Riedel