Skip to content

GitLab

Merged
Opened by Lukas Riedel@lriedelOwner8 of 9 tasks completed8/9 tasks

Resolve "Add Outflow boundary condition for Richards model"

What does this MR do?

Implement the Outflow boundary condition for the Richards model as variant of the Dirichlet BC.

  • Enable OutflowBoundaryCondition for Richards model.
  • Implement Outflow BC by skipping residual accumulation if the numeric flux is negative (net flux into the grid cell).
  • Update test-boundary-condition-manager.cc test for checking that OutflowBoundaryCondition can be used in Richards model.
  • Add ODE system tests for checking that Outflow BC is not applied if it would lead to an inflow.
  • Re-formatted user manual page on boundary conditions. Boundary condition types now appear as regular sub-headings in the TOC tree.

Is there something that needs to be double checked?

No.

Can this MR be accepted?

  • Implemented outflow BC for Richards model
  • Added/Updated tests:
    • Updated test-boundary-condition-manager.cc unit test
    • Added ode_outflow system tests
  • Added/Updated documentation
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

Closes #182 (closed)

Edited by Lukas Riedel