Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !207

Merged
Opened Jun 25, 2020 by Santiago Ospina De Los Ríos@sospinarMaintainer5 of 5 tasks completed5/5 tasks

Fix installation stage

  • Overview 44
  • Commits 20
  • Pipelines 11
  • Changes 36

What does this MR do?

Few things make the installation stage fail when performing make install. Here some fixes for them.

  • When installing DORiE (i.e. make install), many header files are wrong while many others are missing. That makes installation to fail. This MR fixes that and installation now is at least successful.

  • Installation of python dune virtual environment is currently activated by default. This is alright for using the build files but is incorrect for proper installations. This MR fixes that. If the user still wants to install with editable mode, she/he can set the corresponding dune flag for it.

Changes after discussions

  • The CLI can now handle executing DORiE from install directory trees. This is controlled via the DORIE_INSTALL_DIR environment variable.

  • The application docker image now uses the DORiE install tree instead of the build tree to reduce image size, see also #44.

Is there something that needs to be double checked?

Does installation work with dorie-spack?

Can this MR be accepted?

  • Implemented
  • [ ] Added/Updated tests See #201
  • [ ] Added/Updated documentation See #201
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

#195

Edited Aug 04, 2020 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: dorie/dorie!207
Source branch: bugfix/install-header-files

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.