Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !218

Merged
Opened Aug 26, 2020 by Lukas Riedel@lriedelOwner7 of 7 tasks completed7/7 tasks

Resolve "Update C++ standard requirement"

  • Overview 5
  • Commits 4
  • Pipelines 5
  • Changes 4

What does this MR do?

Explicitly sets the C++ standard version for the compiled DORiE libraries. Removes the call to dune_require_cxx_standard(), which seems to have no helpful effect.

Is there something that needs to be double checked?

  • Compiles on macOS (@lriedel)
  • Compiles on macOS (@hbauser)

Can this MR be accepted?

  • Implemented CMake configuration for setting C++17 standard
  • [ ] Added/Updated tests
  • [ ] Added/Updated documentation
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

Closes #198 (closed)

Edited Aug 26, 2020 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: dorie/dorie!218
Source branch: 198-update-c-standard-requirement

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.