Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dorie
  • dorie
  • Merge Requests
  • !28

Merged
Opened Mar 12, 2018 by Lukas Riedel@lriedelOwner4 of 4 tasks completed4/4 tasks

Add test for mass conservation

  • Overview 0
  • Commits 10
  • Pipelines 3
  • Changes 10

What does this MR do?

Add a system test for global mass conservation. It covers two scenarios:

  • static simplex grid
  • adaptive simplex grid

Rectangular grids have been removed from these test to save runtime.

The acceptance threshold for adaptive grids is significantly higher than for static ones, which is due to the fact that the adapt_grid algorithm currently does not conserve water content, see #38.

Is there something that needs to be double checked?

This branch is forked from !14 (merged) and should be merged after it.

Can this MR be accepted?

  • Implemented new executable test-mass-conservation
  • Added system test dorie_mass_conservation
  • Test passes
  • Pipeline test results unchanged

Related issues

Closes #39 (closed).

Edited Mar 12, 2018 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
v1.0 Release
Milestone
v1.0 Release
Assign milestone
Time tracking
Reference: dorie/dorie!28
Source branch: feature/test-mass-conservation