Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !35

Merged
Opened Mar 16, 2018 by Lukas Riedel@lriedelOwner6 of 6 tasks completed6/6 tasks

Resolve "Raise mass conservation limits"

  • Overview 0
  • Commits 2
  • Pipelines 1
  • Changes 2

What does this MR do?

  • Add rectangular grids to the mass conservation tests again
  • Raise mass conservation limits for static(!) grid tests
  • Lower mass conservation limits for adaptive grid tests
  • Fix a bug where an exception in the mass conservation test would not result in the test failing

Is there something that needs to be double checked?

Mass conservation decreased for static cases, but increased for adaptive cases. Now all in the range of one order of magnitude.

Can this MR be accepted?

  • Added new tests
  • Pipeline passing

Related issues

Closes #54 (closed)

Edited Mar 16, 2018 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
v1.0 Release
Milestone
v1.0 Release
Assign milestone
Time tracking
Reference: dorie/dorie!35
Source branch: 54-raise-mass-conservation-limits

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.