Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dorie
  • dorie
  • Merge Requests
  • !82

Merged
Opened Aug 11, 2018 by Lukas Riedel@lriedelOwner22 of 22 tasks completed22/22 tasks

Resolve "Implement new parameterization data input"

  • Overview 27
  • Commits 62
  • Pipelines 28
  • Changes 77

What does this MR do?

Add new options for the input of paramterization data and its attachment to the grid. The old options are removed.

  • Add GridCreator for building grids.
  • Add GridMapper which is called by GridCreator for load-balancing the grid and the mapping data.
  • Upgrade H5File to read datasets with arbitrary H5 data types.
  • Merge !55 (merged) into this.
  • Implement reading a YAML parameterization file in FlowBoundary.
  • Add unit tests for the new classes and functions (use !98 (merged)).
  • Adapt system tests.
  • Add (at least preliminary) documentation on usage of new features.
  • Add pygmsh and h5py to virtualenv.
  • Move creation of GridWrapper out of RichardsSimulation, see #97 (closed).
  • Update docstrings of new classes and RichardsSimulation.
  • [ ] Optional: Rename GridWrapper, see #97 (closed).
  • Remove old parameterization and method run() (See !89 (comment 14708)).
  • Remove old parameterization source files.

Additional performance tasks

  • Replace calls to MPI with calls to Dune::CollectiveCommunication.
  • [ ] Optional: Instantiate objects for GridCreator, GridMapper, and H5File explicitly. Remove template parameters where possible.

Is there something that needs to be double checked?

Not sure yet.

Can this MR be accepted?

  • Implemented new features
  • Added new tests
  • Adapted tests
  • Removed testing executables
  • Pipeline passing
  • Added docs
  • Added entry to CHANGELOG.md
  • Update README.md

Related issues

Closes #86 (closed)

Meta-issue #63 (closed)

See also #97 (closed)

Edited Sep 25, 2018 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: dorie/dorie!82
Source branch: 86-implement-new-parameterization-data-input