Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !89

Merged
Opened Aug 21, 2018 by Santiago Ospina De Los Ríos@sospinarMaintainer5 of 5 tasks completed5/5 tasks

Resolve "Modify RichardsSimulation to have the base class #94."

  • Overview 14
  • Commits 32
  • Pipelines 34
  • Changes 22

What does this MR do?

Modify RichardsSimulation to have the base class #94 (closed).

  • This MR depends on #90 (closed) since the interface is not complete without separation between adaptivity and marking the grid.
  • All the constants on BaseTraits are removed so that RichardsSimulation is using policies introduced in #94 (closed). Nevertheless, a static check is still done for adaptivity in order to allow only UGgrids to be adapted.
  • The suggest_timestep() method is now also implemented in TimeController
  • Method run() is overloaded temporally while !82 (merged) is finished.

Is there something that needs to be double checked?

Can this MR be accepted?

  • Implemented
  • Pipeline passing
  • Added entry to CHANGELOG.md
  • !87 (merged) accepted
  • !91 (merged) accepted

Related issues

Closes #95 (closed), #90 (closed)

Edited Sep 05, 2018 by Santiago Ospina De Los Ríos
Assignee
Assign to
Reviewer
Request review from
Solute Transport Feature
Milestone
Solute Transport Feature
Assign milestone
Time tracking
Reference: dorie/dorie!89
Source branch: 95-modify-richardssimulation-to-have-the-base-class-94

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.