Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • dorie
  • dorie
  • Merge Requests
  • !96

Merged
Opened Aug 26, 2018 by Santiago Ospina De Los Ríos@sospinarMaintainer25 of 25 tasks completed25/25 tasks

Resolve "Couple the TransportSimulation with RichardsSimulation"

  • Overview 106
  • Commits 142
  • Pipelines 88
  • Changes 86

What does this MR do?

Couple TransportSimulation with RichardsSimulation

  • Share adapters between models.
  • Share states with other models (for adaptivity).
  • Implement synchronization of steps algorithm.
  • Manage different output policies.
  • Manage different adaptivity policies.
  • Check infinite loop due to dt in time controller.
  • Check name clash of output names and paths.
  • Check error in conforming fluxes test.
  • Cache flux reconstruction.
  • Add tracer messages in the coupling.
  • Add default files created by dorie create.
  • Add linear solver parameters in inifile.
  • Ensure const-correctness while allowing parameter modifications !96 (comment 20940)
  • Document courant number
  • Remove dummy-transport-simulation-test
  • Output total solute
  • Add outflow boundary conditions
  • Implement outflow in the local operator for finite volumes
  • Check why diffusion coefficent does not affect the solution as expected

Is there something that needs to be double checked?

No.

Can this MR be accepted?

  • Implemented
  • Added test
  • Documented (Doxygen)
  • Documented (Sphinx)
  • Pipeline passing
  • Added entry to CHANGELOG.md

Related issues

Closes #101 (closed), #72 (closed)

Edited Feb 06, 2019 by Lukas Riedel
Assignee
Assign to
Reviewer
Request review from
Solute Transport Feature
Milestone
Solute Transport Feature
Assign milestone
Time tracking
Reference: dorie/dorie!96
Source branch: 101-couple-the-transportsimulation-with-richardssimulation