Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 13
    • Merge Requests 13
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Issues
  • #159

Closed
Open
Opened Aug 09, 2019 by Lukas Riedel@lriedel0 of 1 task completed0/1 task
  • Report abuse
  • New issue
Report abuse New issue

Follow-up from "Resolve "Add upwinding option to Richards FV solver""

The following discussion from !161 (merged) should be addressed:

  • @sospinar started a discussion: (+2 comments)

    The normal vector is positive to the outside of the cell. That means that this the negative value of \frac{\partial u}{\partial \vec{n}}. Of course this is doing the same as before, but I find it more clear if it has the correct sign (as the DG local operator).

The resulting change in 5e15de0e should also have inverted the checks for upwinding. It did not, which is why the upwinding now effectively is a downwinding in the FV solver. The ODE tests did not notice that change, which becomes mostly apparent in transient states.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
3
Labels
Bug Critical Model:Richards
Assign labels
  • View project labels
Reference: dorie/dorie#159