Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 13
    • Merge Requests 13
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Issues
  • #54

Closed
Open
Opened Mar 16, 2018 by Lukas Riedel@lriedel
  • Report abuse
  • New issue
Report abuse New issue

Raise mass conservation limits

Summary

Apparently, !14 (merged) changed the results of the mass conservation test. This might be due to the different time step behavior, as the tests run much faster now. This indicates that global mass conservation also depends on time step size.

What is the current behaviour?

Mass conservation test for static simplex grid fails. Mass conservation is three orders of magnitude worse than expected.

Proposal

  • Raise mass conservation limits to appropriate value
  • Add tests on rectangular grids again, because execution time is much lower now.
Assignee
Assign to
v1.0 Release
Milestone
v1.0 Release
Assign milestone
Time tracking
None
Due date
None
1
Labels
Suggestion
Assign labels
  • View project labels
Reference: dorie/dorie#54