Resolve "Increase encapsulation of TimeController"
What does this MR do?
TimeStepController, which has a more limited set of capabilities and does not manage the model time anymore. The new controller offers management of time steps, but has to be called explicitly to do so.
Changes inside the models:
- models now have a member
timeand fully control it
stepalgorithms re-formulated as infinite loops which either
breakon success or
To-do from discussions:
timea member of
Is there something that needs to be double checked?
Time steps are properly adjusted to changes in BCs (testing in Richards only)
Transport solver still working as intended
[ ] This removes the "minimal step" work-around in theUpdate: Re-introduced the workaround in both models, leading to minimal time steps when boundary conditions change. Will be fixed when merging !121 (merged).
CalculationControllerwhich avoided that boundary conditions were applied to early. There is currently no replacement for this because !121 (merged) will solve this problem within
Can this MR be accepted?
- Added unit test
- Adapted system tests
- Pipeline passing
- Squash commits option set
[ ] Added entry toNo change for users or in the Public API.
Closes #128 (closed)