Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
D
dorie
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 13
    • Merge Requests 13
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • dorie
  • dorie
  • Merge Requests
  • !33

Merged
Opened Mar 13, 2018 by Lukas Riedel@lriedel9 of 9 tasks completed9/9 tasks
  • Report abuse
Report abuse

Resolve "add options for altering DG formulation in local operator"

What does this MR do?

  • Rewrite local operator so support multiple DG schemes & upwinding algorithms, and combinations thereof
  • Add experimental config keys dg.experimental which alter these settings at runtime:
    • method, upwinding, and weights
  • Change default upwinding scheme to none

Is there something that needs to be double checked?

Disabling the upwind scheme...

  • Does not (significantly) change 1D ODE benchmark residuals for homogeneous media
  • Improves 1D ODE benchmark residuals for layered media
  • Reduces deviation to Muphi results in 1D transient benchmarks for homogeneous media
  • Removes timeout issues of reference tests

Can this MR be accepted?

  • Add new keys to parameters.xml
  • Add CMake option -DEXPERIMENTAL_DG_FEATURES
  • Add section on these features to README.md
  • ODE tests pass
  • Test vs Muphi passes

Related issues

Closes #43 (closed)

Edited Mar 15, 2018 by Lukas Riedel
  • Discussion 0
  • Commits 14
  • Pipelines 4
  • Changes 10
Assignee
Assign to
v1.0 Release
Milestone
v1.0 Release
Assign milestone
Time tracking
2
Labels
Critical Enhancement
Assign labels
  • View project labels
Reference: dorie/dorie!33

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.